Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update retcode from symbol #288

Merged
merged 3 commits into from
Apr 18, 2024
Merged

update retcode from symbol #288

merged 3 commits into from
Apr 18, 2024

Conversation

kaitlyn-loftus
Copy link
Contributor

fix terminate! to update solution's retcode with a SciMLBase.ReturnCode instead of a Symbol (raises warning)

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Followed what's in OrdinaryDiffEq.jl

devmotion
devmotion reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! Is the warning a deprecation warning or shown unconditionally? In the latter case it might be nice to add a test that checks that it does not appear anymore with the updated code.

@kaitlyn-loftus
Copy link
Contributor Author

I'm not sure @devmotion. The warning is from here.

devmotion
devmotion approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a simple test, thank you!

@devmotion devmotion merged commit 1ad28dd into SciML:master Apr 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

@devmotion devmotion devmotion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaitlyn-loftus @devmotion @ChrisRackauckas